Add transformer that removes trait definitions #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
reviewed
Sep 11, 2020
smithy-build/src/main/java/software/amazon/smithy/build/plugins/RemoveSharedShapesPlugin.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
shape-plugin
branch
4 times, most recently
from
2296834
to
6b7404b
Compare
srchase
force-pushed
the
shape-plugin
branch
from
6b7404b
to
e532889
Compare
srchase
changed the title
mtdowling
requested changes
Sep 15, 2020
smithy-build/src/main/java/software/amazon/smithy/build/transforms/RemoveTraitDefinitions.java
Outdated
Show resolved
Hide resolved
smithy-build/src/main/java/software/amazon/smithy/build/transforms/RemoveTraitDefinitions.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Sep 15, 2020
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ScrubTraitDefinitions.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CR adds a transformer that removes trait definitions. This enables sharing models where the trait versions may vary. When consuming models produced by this plugin, it is necessary to assure that the requisite traits sources are imported.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.