Add response code binding to http binding index #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the httpResponseCode trait to the http binding index, including a new RESPONSE_CODE location.
|
Does this automatically ensure that members bound to the |
This adds a trait conflict list for httpResponseCode and adds that trait to the conflict lists for the other http binding traits.
|
It wouldn't have been possible to bind to the payload, because it's the wrong type, and it wouldn't get bound to the document because that implicit binding only happens when there's no explicit one. It could have, however, been bound to other parts of the request. I updated the conflicts lists so that can no longer happen. |
mtdowling
approved these changes
Sep 17, 2020
mtdowling
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the httpResponseCode trait to the http binding
index, including a new RESPONSE_CODE location.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.