Improve information available from diffs #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a lot more details to the result of a ModelDiff, including access to the raw Differences between the models, access to the old and new models through the Differences object, access to the old validation events and new validation events, and access to the diff events. Helper methods were added to ModelDiff.Result to detect which validation events were introduced by a change, which validation events were resolved by a change, and if there are breaking changes in the diff (e.g., events that are ERROR or DANGER). Note that any kind of suppression of diff events would need to be applied and managed outside of this helper functionality. Added some missing equals and hashCode implementations.
JordonPhillips
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a lot more details to the result of a ModelDiff,
including access to the raw Differences between the models, access to
the old and new models through the Differences object, access to the old
validation events and new validation events, and access to the diff
events. Helper methods were added to ModelDiff.Result to detect which
validation events were introduced by a change, which validation
events were resolved by a change, and if there are breaking changes in
the diff (e.g., events that are ERROR or DANGER). Note that any kind of
suppression of diff events would need to be applied and managed outside
of this helper functionality.
Added some missing equals and hashCode implementations.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.