Fix media type handling of unions as payloads #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a case where if a union shape is marked with the httpPayload trait, we wouldn't resolve a proper mediaType. This caused an NPE. The code that determines the media type has been updated to treat unions like structures, and a more helpful message was added in case a media type can't be resolved at some point in the future.
JordonPhillips
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a case where if a union shape is marked with the httpPayload
trait, we wouldn't resolve a proper mediaType. This caused an NPE. The
code that determines the media type has been updated to treat unions
like structures, and a more helpful message was added in case a media
type can't be resolved at some point in the future.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.