Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some null value clarifications #596

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Add some null value clarifications #596

merged 2 commits into from
Oct 7, 2020

Conversation

mtdowling
Copy link
Member

Map keys, set values, and union members do not support null.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mtdowling
Add some null value clarifications
4bc900e 
Map keys, set values, and union members do not support null.
@mtdowling mtdowling requested a review from kstich October 7, 2020 02:58
kneekey23
kneekey23 reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@kneekey23 kneekey23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you edit the language above the @required trait as well to be more clear in this PR possibly too? :)

@mtdowling mtdowling requested review from srchase and removed request for kstich October 7, 2020 16:09
@mtdowling mtdowling merged commit 395e14f into master Oct 7, 2020
@mtdowling mtdowling deleted the null-clarifications branch December 11, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneekey23 kneekey23 kneekey23 left review comments

@srchase srchase srchase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtdowling @srchase @kneekey23