Validate sensitive trait targets #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Members should not be marked with the sensitive trait if they target shapes marked as sensitive or shapes that are generally code-generated. It is safer to define a complex type as sensitive rather than to reference a complex type from a member marked as sensitive. This helps prevent issues where the sensitive trait may get forgotten on the member even though a structure/union/enum is inherently sensitive.
kstich
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Members should not be marked with the sensitive trait if they target
shapes marked as sensitive or shapes that are generally code-generated.
It is safer to define a complex type as sensitive rather than to reference
a complex type from a member marked as sensitive. This helps prevent issues
where the sensitive trait may get forgotten on the member even though a
structure/union/enum is inherently sensitive.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.