Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in docs to protocol tests #615

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

rcoh
Copy link
Contributor

@rcoh rcoh commented Oct 26, 2020

Description of changes:
I updated the link to 1.3.0—let me know if you'd prefer master or somewhere else. Currently, the link just 404s.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I updated the link to 1.3.0—let me know if you'd prefer master or somewhere else. Currently, the link just 404s.
Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links should use the __smithy_version__ version replacement instead of 1.3.0 directly so this stays up to date as we publish new versions.

@rcoh
Copy link
Contributor Author

rcoh commented Oct 27, 2020

Updated, generated docs locally, and manually verified the links are correctly generated.

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kstich kstich merged commit 250f57f into smithy-lang:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants