Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't conflict URI if an endpoint prefix is present #626

Merged
merged 6 commits into from
Nov 12, 2020
Merged

Don't conflict URI if an endpoint prefix is present #626

merged 6 commits into from
Nov 12, 2020

Conversation

JordonPhillips
Copy link
Contributor

Two URIs can't conflict if one has an endpoint prefix, or if both have an endpoint prefix that can't resolve to the same prefix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mtdowling
mtdowling requested changes Nov 7, 2020
View reviewed changes
Copy link
Member

@mtdowling mtdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this also need a spec update. Maybe to the endpoint trait, but the URI trait conflict section could link to the longer description of deconflicting http traits in the endpoint trait?

...esources/software/amazon/smithy/model/errorfiles/validators/http-uri-conflict-validator.json Outdated Show resolved Hide resolved
@JordonPhillips JordonPhillips merged commit 076547f into smithy-lang:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtdowling mtdowling mtdowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordonPhillips @mtdowling