Set OpenAPI requestBody to required if necessary #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested review from
mtdowling,
kstich and
srchase
and removed request for
mtdowling
srchase
reviewed
Dec 4, 2020
...hy-openapi/src/test/java/software/amazon/smithy/openapi/fromsmithy/OpenApiConverterTest.java
Outdated
Show resolved
Hide resolved
This updates the OpenAPI conversion to set an operation's `requestBody` as required if the operation has an `httpPayload` member and that member is required or if the operation has no `httpPayload` member but does have a required member bound to the document.
JordonPhillips
force-pushed
the
openapi-required-payload
branch
from
35f180b to
d9f7fea
Compare
srchase
approved these changes
Dec 4, 2020
mtdowling
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This updates the OpenAPI conversion to set an operation's
requestBodyas required if the operation has anhttpPayloadmember and that member is required or if the operation has nohttpPayloadmember but does have a required member bound to the document.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.