Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol tests for String & Enum HTTP payloads #747

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

rcoh
Copy link
Contributor

@rcoh rcoh commented Mar 22, 2021

Description of changes: There are no protocol tests for Strings or enum-marked-strings for restJson.

Tests: The Rust SDK passes these tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

Would you be willing to add a couple tests for responses? No worries if not, we can add them after as well.

@rcoh
Copy link
Contributor Author

rcoh commented Mar 29, 2021

yeah I have them locally actually, let me copy them over

@rcoh rcoh requested a review from kstich March 30, 2021 13:32
@kstich kstich merged commit e480e6f into smithy-lang:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants