Support service renames when flattening namespaces #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested changes
Apr 6, 2021
JordonPhillips
approved these changes
Apr 6, 2021
mtdowling
reviewed
Apr 6, 2021
| @@ -164,9 +164,18 @@ private ShapeId updateNamespace(ShapeId shapeId, String namespace) { | |||
| return shapeWalker.walkShapes(service).stream() | |||
| .filter(FunctionalUtils.not(Prelude::isPreludeShape)) | |||
| .map(shape -> Pair.of(shape.getId(), updateNamespace(shape.getId(), config.getNamespace()))) | |||
| .map(pair -> applyServiceRenames(pair, service)) | |||
There was a problem hiding this comment.
Nit: ideally we can destructure pairs before calling methods with them. That would give the left and right shape ID a name so it's easier to understand the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for service renames (#734) when using the
flattenNamespacestransformer.Any shapes that have been configured on the service to be renamed will also be flattened into the target namespace.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.