Parse numbers as BigDecimal or BigInteger when needed. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
requested review from
JordonPhillips,
kstich and
mtdowling
as code owners
JordonPhillips
requested changes
Apr 9, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/resources/software/amazon/smithy/model/loader/valid/traits.smithy
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/node/internal/NodeHandler.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
fix-parse-big-decimals
branch
from
9b84b8f
to
a4dcceb
Compare
srchase
changed the title
JordonPhillips
approved these changes
Apr 12, 2021
Comment on lines
+189
to
+195
| "com.example#bDecimal": 2E+308 | ||
| } | ||
| }, | ||
| "com.example#Z": { | ||
| "type": "string", | ||
| "traits": { | ||
| "com.example#bDecimal": 2E+308 |
There was a problem hiding this comment.
I think one of these was supposed to use a lowercase e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, numbers greater than 9223372036854775807 fail to be parsed from the IDL with
NumberFormatException, even when the underlying implementation supports BigDecimal and BigInteger.This PR updates the IdlModelParser and NodeHandler to use fall back to using
BigDecimalorBigIntegerwhere appropriate.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.