Update semantic validation of OPTIONS #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested changes
Aug 16, 2021
...in/java/software/amazon/smithy/model/validation/validators/HttpMethodSemanticsValidator.java
Outdated
Show resolved
Hide resolved
* OPTIONS do support payloads * OPTIONS should rarely, if ever, be modeled. They should instead just be implementation details of how CORS works.
mtdowling
force-pushed
the
options-method-semantics-updates
branch
from
dab3f0c
to
b8059aa
Compare
JordonPhillips
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be implementation details of how CORS works.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.