Fail by default when a build plugin can't be found #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithy-build previously just logged an info when a build plugin couldn't be found on the classpath. This was a bad user experience for actually using Smithy. The requirement to be able to ignore a missing build plugin is really an edge case for build tools that want to be able to build just models and ignore other plugins, so those tools should opt-in to that behavior instead. Just logging was way too subtle for diagnosing issues with config files and dependencies.
mtdowling
requested review from
DavidOgunsAWS,
JordonPhillips and
kstich
as code owners
gosar
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smithy-build previously just logged an info when a build plugin couldn't
be found on the classpath. This was a bad user experience for actually
using Smithy. The requirement to be able to ignore a missing build
plugin is really an edge case for build tools that want to be able to
build just models and ignore other plugins, so those tools should opt-in
to that behavior instead. Just logging was way too subtle for diagnosing
issues with config files and dependencies.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.