Add rest-json protocol test updates #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the In addition, I think that some of these tests duplicate, or are very similar to, some of the existing |
nateprewitt
force-pushed
the
rest-json-content-types
branch
from
69db653
to
b31691f
Compare
adamthom-amzn
approved these changes
Oct 5, 2021
These changes are to help codify current Smithy behavior and ensure all generated clients are conformant with expectations for the rest-json protocol. This includes: * Validating what an empty body looks like when handling structured and unstructured input. * Validating correct Content-Type headers are sent with payloads and can be overwritten with members targeting an HTTP header. * Validating methods that should not serialize a body are correctly omitting relevant headers.
nateprewitt
force-pushed
the
rest-json-content-types
branch
from
b31691f
to
368f817
Compare
JordonPhillips
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to help codify current Smithy behavior and ensure all generated clients are conformant with expectations for the rest-json protocol. Each test should have an explanation of what it's trying to achieve and why that's relevant to clients generated to Smithy.
Added checks in
http-content-type.smithy:From initial testing, Smithy clients appear to already follow these requirements but they aren't formally specified in any single test suite. Some of these checks are redundant with tests from
http-payload.smithyandhttp-headers.smithy, but have been added to this file to reduce cognitive load when trying to understand how a client behaves in these cases.