Allow serializing prelude in the node serializer #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Oct 22, 2021
smithy-model/src/main/java/software/amazon/smithy/model/shapes/ModelSerializer.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/ModelSerializer.java
Outdated
Show resolved
Hide resolved
This adds a configuration option to the node model serializer that disables filtering the prelude from the output. This is mostly to enable alternate implementation to base their prelude understanding off of a JSON AST version of the prelud model (see smithy-lang#947).
JordonPhillips
force-pushed
the
enable-prelude-serialization
branch
from
bf2a0d8 to
2c50d74
Compare
mtdowling
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration option to the node model serializer that disables filtering the prelude from the output. This is mostly to enable alternate implementation to base their prelude understanding off of a JSON AST version of the prelud model (see #947).
I also noticed that the test to make sure the prelude wasn't included by default was wrong - it was still assuming the pre-1.0 ast format. So I fixed that while I was there.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.