Clarify http payload binding error message #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
approved these changes
Oct 25, 2021
mtdowling
requested changes
Oct 25, 2021
...in/java/software/amazon/smithy/model/validation/validators/HttpMethodSemanticsValidator.java
Outdated
Show resolved
Hide resolved
This adds some more verbose clarification for when somebody binds a member to the http request body for a method where that binding may not be permitted in all http clients.
JordonPhillips
force-pushed
the
verbose-http-error
branch
from
72a7a4c to
4bdca6c
Compare
|
The documentation thing is unrelated to this, it's a python 3.10 thing. I'll get a separate pr up to address that. |
mtdowling
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more verbose clarification for when somebody binds a member to the http request body for a method where that binding may not be permitted in all http clients.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.