Add design for inline operation input/output shapes #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
inline-io
branch
from
dbaf424
to
c2366ee
Compare
mtdowling
reviewed
Oct 30, 2021
mtdowling
reviewed
Oct 30, 2021
mtdowling
requested changes
Nov 2, 2021
This updates the ABNF to be more simplified and generic. This makes it more consistent with the rest of the ABNF where things like what property keys are allowed aren't defined. This makes writing a generic parser easier, though it does impose more on validation.
|
Updated. In the update I also included an updated ABNF that is simpler and less prescriptive. The rest of our ABNF is fairly generic, technically permitting invalid properties. I think that's actually better in that it makes it easy to write a generic parser that conforms to the ABNF. Applications like syntax highlighters, for instance, don't need to care about that level of detail. |
mtdowling
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.