Clarify doc about sources plugin #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
changed the title
mtdowling
requested changes
Nov 11, 2021
| @@ -1446,14 +1446,14 @@ Smithy models contained within the JAR are copied as a source model while the | |||
| JAR itself is not copied. If there are no source models, an empty manifest is | |||
| created. | |||
|
|
|||
| When applying a projection, a new model file is created that contains only | |||
| the shapes, trait definitions, and metadata that were defined in a source | |||
| When building a different projection, a new model file is created that contains | |||
There was a problem hiding this comment.
I don't see the reason for the word "different" here. Not sure what it means.
| When applying a projection, a new model file is created that contains only | ||
| the shapes, trait definitions, and metadata that were defined in a source | ||
| When building a different projection, a new model file is created that contains | ||
| only the shapes, trait definitions, and metadata that were defined in a source | ||
| model *and* all of the newly added shapes, traits, and metadata. |
There was a problem hiding this comment.
Would be nice to clarify what "newly added" means here. I thought that was the main reason for the PR.
mtdowling
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.