Fix filterSuppressions handling of members #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
reviewed
Nov 19, 2021
| } | ||
|
|
||
| private void filterMetadata( | ||
| private Model filterMetadata( |
There was a problem hiding this comment.
minor: Can you add a check to make sure the model has suppressions defined before recreating it?
There was a problem hiding this comment.
Good suggestion. Added a check to make sure suppressions changed before recreating. Also added couple tests cases for 1. no suppressions 2. no change to suppressions.
`builder.addShape` does not allow adding member shapes directly. Instead use ReplaceShapes which handles replacing member shapes too.
gosar
force-pushed
the
filterSuppression-member
branch
from
75540b0
to
f480d1a
Compare
mtdowling
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
FilterSuppressions uses builder.addShape here ) to update the traits on all shapes, including member shapes. However,
builder.addShapedoes not support updating member shapesdirectly.
Description of changes:
Instead use ReplaceShapes which handles replacing member shapes too.
Testing:
Updated the traits.smithy test cases to cover the member case. They failed before this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.