Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http-content-type protocol tests with mismatched params/headers #993

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Nov 23, 2021

Issue #, if available:
aws/aws-sdk-js-v3#3058

Description of changes:
RestJsonTestPayloadStructure and RestJsonHttpWithHeadersButNoPayload had a testId param but no assertion for X-Amz-Test-Id header. Made the params/headers match.

Testing:
Regenerated test in aws-sdk-js-v3 and confirmed it fixes aws/aws-sdk-js-v3#3058.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gosar gosar requested a review from a team as a code owner November 23, 2021 22:51
@gosar gosar merged commit 03909ca into smithy-lang:main Nov 24, 2021
@gosar gosar deleted the content-type-tests branch November 24, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RestJson tests are failing for server protocols
2 participants