Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Ztoc creation #233

Closed
vkuzniet opened this issue Dec 13, 2022 · 0 comments · Fixed by #346
Closed

Refactor the Ztoc creation #233

vkuzniet opened this issue Dec 13, 2022 · 0 comments · Fixed by #346
Assignees
Labels
feature New feature or request

Comments

@vkuzniet
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Per #103, the snapshotter's Ztoc creation needs to be adjusted to allow for easy addition of new types of compression algorithms. For more details, please refer to the design doc in #103.
This story requires implementing the following:

  1. TocBuilder (please ensure that this type will be a common one for any compression algorithm)
  2. Interface ZinfoBuilder with specific implementation for gzip (aka GzipZinfoBuilder)
  3. ztoc.Builder, which combines 1 and 2. It will be shared for any compression algorithm. For more details see the design doc from Ztoc should be separated from compression #103.
  4. soci.buildSociIndex must be using ztoc.Builder for building Ztoc.

Describe the solution you'd like
The steps to implement are outlined in the above section.

Describe alternatives you've considered
Keep everything as is.

Additional context
#103

@vkuzniet vkuzniet added the feature New feature or request label Dec 13, 2022
@Kern-- Kern-- moved this to ❓ Ungroomed in soci-snapshotter Dec 15, 2022
@Kern-- Kern-- moved this from ❓ Ungroomed to 📋 Backlog in soci-snapshotter Dec 15, 2022
@djdongjin djdongjin self-assigned this Feb 7, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in soci-snapshotter Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants