-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guided alignments in Sockeye. #1105
Comments
Hi Toms, At this point, the metadata branch is somewhat out of sync with main, but it could still be helpful as a reference. One path forward would be to follow how metadata is woven through data preparation and training in the metadata branch and add alignment tracking in similar places in the main branch. Best, |
Hi Michael,
Do you have any preference? Or do you see another way forward? Thanks, P.S. We were surprised that dropout on attention is implemented post and not pre-softmax. Post-softmax seems to be standard in transformers. Do you know of why that is? |
Hi Ingus, I'm not familiar with the internals of If the inference implementation doesn't have the dropout issue, one option would be also using this implementation during training when the option for guided alignments is active. This may be a shorter version of the reimplementation path you mentioned. Best, |
Hello Michael, We're doing some final internal checks on the changes we've made (it's about 1000 lines of changes (づ。◕‿‿◕。)づ), we'll probably do the pull request very soon. Thanks, |
It sounds like you've made a lot of progress toward your goal. If you're primarily making these changes to enable your own work, you could keep them on a fork of Sockeye without the need to go through a full code review. If you're interested in merging your changes into Sockeye's main branch, you could run additional experiments to verify the following:
|
Hello Michael, We've prepared a report looking over the ups and downs of adding alignment matrices to Sockeye. I will open a pull request promptly. ٩(◕‿◕)۶ Thanks, |
Hi!
We finally have time to reopen work on guided alignments for Sockeye 3
To recap: guided alignments are handy for formatted document translation, non-translatable entity and placeholder handling, and variations of automatic post-editing. Guided alignments are described in this paper Jointly Learning to Align and Translate with Transformer Models
Previously we were recommended to start from metadata branch. Would it still be the best point from where to start? If so, would getting it up-to-date be complicated?
Cheers!
Toms
The text was updated successfully, but these errors were encountered: