-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tailwind): Add font-size aliases for text utilities #5
feat(tailwind): Add font-size aliases for text utilities #5
Conversation
Thank you for your contribution. Wouldn't be easier to add directly these aliases as tokens here? For example "xl": { "value": "{typography.text-1}" } |
@GianlucaGuarini Thanks for looking into it! Yes, that could make sense. I adjusted the config to generate e.g. Also, updating the token definitions in |
@domirs can you please have a look at it as well?
Isn't this technically a breaking change? Probably we need to bump a new major release for it |
@GianlucaGuarini I’ve updated the config to only remove the I think considering reducing redundancy in other |
Thank you @fkapsahili for your contribution. We will inform our design team that these tokens might need to be renamed in future |
This PR introduces new font-size aliases (
sm
,base
,lg
,xl
) to the existingtext-<number>
utilities to the Tailwind configuration. The current config generates classes liketext-text-1
, which can seem unintuitive and redundant. Additionally, the existing setup prevents the use of default Tailwind utilities such astext-sm
andtext-base
.Prerequisites
Content
Tests
text-<number>
partstext-<number>
utilities