Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT PULL] Typo fixes #982

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[GIT PULL] Typo fixes #982

merged 2 commits into from
Nov 22, 2023

Conversation

guillemj
Copy link
Contributor


git request-pull output:

The following changes since commit 9dc95a03e4a764e42b9e62990bb00feb9307ba63:

  test/no-mmap-inval: 0 return is fine too (2023-11-07 08:05:52 -0700)

are available in the Git repository at:

  https://github.com/guillemj/liburing pu/typos

for you to fetch changes up to 2c89b57f3d55b2e3098a629e8aabe659fd5ec138:

  Fix typos (2023-11-10 01:49:41 +0100)

----------------------------------------------------------------
Guillem Jover (2):
      man/io_uring_queue_init.3: Fix typo
      Fix typos

 README                       | 2 +-
 make-debs.sh                 | 2 +-
 man/io_uring_queue_init.3    | 2 +-
 man/io_uring_register.2      | 2 +-
 src/setup.c                  | 2 +-
 test/eventfd-reg.c           | 2 +-
 test/file-verify.c           | 2 +-
 test/multicqes_drain.c       | 2 +-
 test/socket-getsetsock-cmd.c | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <foo.bar@gmail.com>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

123456789+username@users.noreply.github.com

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <axboe@kernel.dk>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

Warned-by: lintian
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Warned-by: codespell
Signed-off-by: Guillem Jover <guillem@hadrons.org>
@axboe axboe merged commit b2cfad6 into axboe:master Nov 22, 2023
13 checks passed
@guillemj guillemj deleted the pu/typos branch December 17, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants