New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join scripts: don't overwrite config.toml unless explicitly told to do so #355

Open

ggutoski opened this issue Mar 9, 2022 · 1 comment

Contributor

ggutoski commented Mar 9, 2022

From #347 (comment)

it's kinda weird that the standard way to start the node always overwrites the config in place?
It feels like overwritting the config with default config should be only happening with a special parameter no?

I agree. We need to overhaul and simplify the join scripts.

ggutoski mentioned this issue

Non default laddr port configuration setting seems to be ignored when using node.sh script #347

Closed

Member

milapsheth commented Mar 9, 2022

Yeah, but we need to be careful when we do change the default config to notify users in that case. A lot of them won't notice it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment