Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an option not to shuffle the merged dataset #1393

Closed
5 tasks done
seungduk-yanolja opened this issue Mar 11, 2024 · 2 comments
Closed
5 tasks done

Need an option not to shuffle the merged dataset #1393

seungduk-yanolja opened this issue Mar 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@seungduk-yanolja
Copy link
Contributor

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.

🔖 Feature description

Sometimes, it is a strategy to keep the dataset order as listed in the config. In that case, we need to prevent shuffling the merged dataset.

✔️ Solution

Add a config parameter that prevents shuffling.

❓ Alternatives

No response

📝 Additional Context

No response

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
@seungduk-yanolja seungduk-yanolja added the enhancement New feature or request label Mar 11, 2024
@ehartford
Copy link
Collaborator

I agree with the sentiment.

The answer has always been "just comment out the shuffle line in the code"

But really what makes Axolotl stand out among these tools is that it's config based instead of making users change code.

I believe that putting these rich options into the config file will give Axolotl a huge usability advantage.

@seungduk-yanolja
Copy link
Contributor Author

I agree with the sentiment.

The answer has always been "just comment out the shuffle line in the code"

But really what makes Axolotl stand out among these tools is that it's config based instead of making users change code.

I believe that putting these rich options into the config file will give Axolotl a huge usability advantage.

Thank you for agreeing :)
I have just written a PR addressing this issue. Please take a look when you have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants