Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/marp 1481 update connectors to v12 #22

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Feature/marp 1481 update connectors to v12 #22

merged 7 commits into from
Nov 27, 2024

Conversation

tvtphuc-axonivy
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

Test Results

12 tests  +10   12 ✅ +12   8s ⏱️ +8s
 2 suites ± 0    0 💤 ± 0 
 2 files   ± 0    0 ❌ ± 0 

Results for commit 9a3d237. ± Comparison against base commit baec9d4.

This pull request removes 2 and adds 12 tests. Note that renamed tests count towards both. 
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ Unknown test
com.axonivy.connector.vertexai.test.utils.GeminiDataRequestServiceUtilTest ‑ Unknown test

com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testCreateRequestBody
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testGenerateHttpRequestBasedOnModel_GeminiModel
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testGenerateHttpRequestBasedOnModel_VertexAI_Gemini
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testGetAccessToken
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testGetAccessTokenThrowsIOException
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testSendRequestToGemini_ServerOverLoad
com.axonivy.connector.vertexai.test.service.GeminiDataRequestServiceTest ‑ testSendRequestToGemini_SuccessResponse
com.axonivy.connector.vertexai.test.utils.GeminiDataRequestServiceUtilTest ‑ extractHtmlString_multiple_p_tags_test
com.axonivy.connector.vertexai.test.utils.GeminiDataRequestServiceUtilTest ‑ extractHtmlString_test
com.axonivy.connector.vertexai.test.utils.GeminiDataRequestServiceUtilTest ‑ extractImgAttribute_test
…

♻️ This comment has been updated with latest results.

nqhoan-axonivy
nqhoan-axonivy requested changes Nov 27, 2024
View reviewed changes
pom.xml Outdated
@@ -3,7 +3,7 @@
<groupId>com.axonivy.connector.vertexai</groupId>
<name>vertexai-google</name>
<artifactId>vertexai-google-modules</artifactId>
<version>10.0.25-SNAPSHOT</version>
<version>12.0.0</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing -SNAPSHOT, please check other places also

nqhoan-axonivy
nqhoan-axonivy approved these changes Nov 27, 2024
View reviewed changes
Copy link

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvtphuc-axonivy tvtphuc-axonivy merged commit e26c35a into master Nov 27, 2024
7 checks passed
@tvtphuc-axonivy tvtphuc-axonivy deleted the feature/MARP-1481-Update-connectors-to-v12 branch November 27, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqhoan-axonivy nqhoan-axonivy nqhoan-axonivy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvtphuc-axonivy @nqhoan-axonivy