public-api fails to run

[Billy99]

public-api is reporting failures when run with the latest nightly (after rustup update), seeing:

$ cargo xtask public-api
:
Error: aya failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya.json)::build()
    1: missing field `const` at line 1 column 653
aya-obj failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_obj.json)::build()
    1: missing field `synthetic` at line 1 column 375
aya-log failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_log.json)::build()
    1: missing field `synthetic` at line 1 column 371
aya-log-common failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_log_common.json)::build()
    1: missing field `const` at line 1 column 866
aya-log-parser failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_log_parser.json)::build()
    1: missing field `const` at line 1 column 781
aya-ebpf failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_ebpf.json)::build()
    1: missing field `synthetic` at line 1 column 375
aya-ebpf-bindings failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_ebpf_bindings.json)::build()
    1: missing field `bindings` at line 1 column 464
aya-ebpf-cty failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_ebpf_cty.json)::build()
    1: missing field `bindings` at line 1 column 3629
aya-log-ebpf failed to check public API

Caused by:
    0: public_api::Builder::from_rustdoc_json(/home/bmcfall/src/aya/target/doc/aya_log_ebpf.json)::build()
    1: unknown variant `use`, expected one of `module`, `extern_crate`, `import`, `union`, `struct`, `struct_field`, `enum`, `variant`, `function`, `trait`, `trait_alias`, `impl`, `type_alias`, `opaque_ty`, `constant`, `static`, `foreign_type`, `macro`, `proc_macro`, `primitive`, `assoc_const`, `assoc_type` at line 1 column 312

Short term fix is to pin nightly to before the break, then unpin once dependent packages are patched and released.

[Billy99]

Tracking:
cargo-public-api/cargo-public-api#616
rust-lang/rustdoc-types#32

[Billy99]

Still waiting on a release of cargo-public-api. PR for a release has been pushed but not merged (cargo-public-api/cargo-public-api#625). It should merge in a day or two.

As a temporary workaround, #1028 pins rust to nightly-2024-09-09 until public-api fixed if needed.