Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow format timeouts to be set individually #1273

Closed
Tracked by #1259
misumisumi opened this issue Jun 1, 2024 · 2 comments · Fixed by #1275
Closed
Tracked by #1259

Allow format timeouts to be set individually #1273

misumisumi opened this issue Jun 1, 2024 · 2 comments · Fixed by #1275
Labels
enhancement New feature or request

Comments

@misumisumi
Copy link
Collaborator

Feature description

Currently, the timeout for format on save is set to a uniform 1000 ms. (code)
Some formatters require more than 1000 ms to complete, causing a timeout error.

Can this be modified so that it can be set per formatter or inherits the timeout setting for none-ls?

Additional information

No response

@misumisumi misumisumi added the enhancement New feature or request label Jun 1, 2024
@ayamir
Copy link
Owner

ayamir commented Jun 2, 2024

We can make it a configurable option which applies for all formatter. IMO no need to use none-ls to configure it b/c it's lsp that is used instead of the formatter from none-ls for some language.

@ayamir ayamir linked a pull request Jun 2, 2024 that will close this issue
@Jint-lzxy
Copy link
Collaborator

#1275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants