Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "view" link is visible when links have not been supplied #33

Closed
danielcgold opened this issue Mar 9, 2018 · 5 comments
Closed

The "view" link is visible when links have not been supplied #33

danielcgold opened this issue Mar 9, 2018 · 5 comments

Comments

@danielcgold
Copy link

See screenshots!
screen shot 2018-03-09 at 1 20 19 pm

screen shot 2018-03-09 at 1 20 49 pm

@ayastreb
Copy link
Owner

Hi @danielcgold
thanks for reporting this!
How do you provide locations - from page front matter or from data files?
Can you show how your {% google_map %} tag looks like?

@danielcgold
Copy link
Author

No prob!

Yea, from front matter. It looks like this:


hong-kong.markdown

---
title: Hong Kong’s Hidden Photo Spots
date: 2017-07-10 16:15:00 Z
location:
- title: Choi Hung Rainbow Estate
  latitude: 22.334757
  longitude: 114.20734
- title: Ping Shek Estate
  latitude: 22.333634
  longitude: 114.209081
- title: Montane Mansion
  latitude: 22.28449
  longitude: 114.211968
- title: Lai Tak Tsuen
  latitude: 22.278229
  longitude: 114.194438
- title: Instagram Pier
  latitude: 22.289601
  longitude: 114.132743
---

and the google maps tag looks like this

{% google_map width="100%" %}

@ayastreb
Copy link
Owner

Sorry for the delay!
What is the use-case you're trying to achieve? Do you want to display a map with multiple markers, where each marker has a popup, but does not have a link?

Right now, if you specify locations in page front matter data - they all will have this page URL as popup URL. If you specify locations from data file and use it with src attribute - then popups will not have URLs.

@ayastreb
Copy link
Owner

I've just released v2.3.0, it does not use page url if there are multiple locations on the page now.

@danielcgold
Copy link
Author

Woo!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants