Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify method for adding files to a pass #12

Open
aydenp opened this issue Nov 25, 2021 · 0 comments
Open

Unify method for adding files to a pass #12

aydenp opened this issue Nov 25, 2021 · 0 comments
Labels
api breaking Will result in an API change that breaks existing uses enhancement New feature or request
Milestone

Comments

@aydenp
Copy link
Owner

aydenp commented Nov 25, 2021

Since #4 we have two ways to add files by Data (rather than one already on disk):

  • func addFile(named:,from:)
  • func addData(named:,from:)

The difference is that the first creates a temporary file on-disk, where the second does it entirely in memory. This is a workaround because the first doesn't support subdirectories (#6).

Ideally, only one of these should exist. Based on the outward appearance of the API, I would vote for the second which doesn't write to disk. This will also be important for #9, where these models may be reused.

@aydenp aydenp added enhancement New feature or request api breaking Will result in an API change that breaks existing uses labels Nov 25, 2021
@aydenp aydenp added this to the 2.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking Will result in an API change that breaks existing uses enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant