From 5a192084297c8819a5791fd693a261c34fbf1fa6 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 17 Sep 2017 23:18:59 -0400 Subject: [PATCH] test: add missing assertion This commit adds an assertion to an existing try...catch statement. Unfortunately, assert.throws() cannot be used because the operation succeeds on some platforms, throws EINVAL on some platforms, and throws ENOPROTOOPT on others. PR-URL: https://github.com/nodejs/node/pull/15519 Reviewed-By: Luigi Pinca Reviewed-By: Yuta Hiroto Reviewed-By: James M Snell --- test/parallel/test-dgram-multicast-set-interface.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-dgram-multicast-set-interface.js b/test/parallel/test-dgram-multicast-set-interface.js index c065683f53..2900cb8973 100644 --- a/test/parallel/test-dgram-multicast-set-interface.js +++ b/test/parallel/test-dgram-multicast-set-interface.js @@ -33,11 +33,14 @@ const dgram = require('dgram'); socket.bind(0); socket.on('listening', common.mustCall(() => { // Try to set with an invalid interfaceAddress (wrong address class) + // + // This operation succeeds on some platforms, throws `EINVAL` on some + // platforms, and throws `ENOPROTOOPT` on others. This is unpleasant, but + // we should at least test for it. try { socket.setMulticastInterface('::'); - throw new Error('Not detected.'); } catch (e) { - console.error(`setMulticastInterface: wrong family error is: ${e}`); + assert(e.code === 'EINVAL' || e.code === 'ENOPROTOOPT'); } socket.close();