From 9cda1c9ae4a3050b554705e2651a0561b5ec9ace Mon Sep 17 00:00:00 2001
From: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Date: Mon, 7 Aug 2017 11:13:01 +0200
Subject: [PATCH] test: add known issue for vm module
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GlobalPropertySetterCallback() does not check the
property on the sandbox. It wrongly throws an error
instead of updating `x`.

PR-URL: https://github.com/nodejs/node/pull/14661
Ref: https://github.com/nodejs/node/issues/12300
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
---
 test/known_issues/test-vm-strict-mode.js | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 test/known_issues/test-vm-strict-mode.js

diff --git a/test/known_issues/test-vm-strict-mode.js b/test/known_issues/test-vm-strict-mode.js
new file mode 100644
index 0000000000..9528944732
--- /dev/null
+++ b/test/known_issues/test-vm-strict-mode.js
@@ -0,0 +1,17 @@
+'use strict';
+// https://github.com/nodejs/node/issues/12300
+
+require('../common');
+const assert = require('assert');
+const vm = require('vm');
+
+const ctx = vm.createContext({ x: 42 });
+
+// The following line wrongly throws an
+// error because GlobalPropertySetterCallback()
+// does not check if the property exists
+// on the sandbox. It should just set x to 1
+// instead of throwing an error.
+vm.runInContext('"use strict"; x = 1', ctx);
+
+assert.strictEqual(ctx.x, 1);