Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Millet hasn't recognized glob syntax from v0.14.4 onwards #62

Closed
Knaoinr opened this issue Aug 29, 2024 · 1 comment
Closed

Millet hasn't recognized glob syntax from v0.14.4 onwards #62

Knaoinr opened this issue Aug 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Knaoinr
Copy link

Knaoinr commented Aug 29, 2024

Environment

  • Millet version: 0.14.6
  • Editor version: VSCode 1.92.2
  • OS version: macOS 12.7.4

Steps to reproduce

Set workspace root to something like **/code/sources.mlb.

Expected behavior

Millet detects all sources.mlb files present.

Actual behavior

Millet does not recognize any files.

image

Downgrading Millet to v0.14.3 fixes this issue.

@Knaoinr Knaoinr added the bug Something isn't working label Aug 29, 2024
@azdavis
Copy link
Owner

azdavis commented Sep 20, 2024

sorry for the delay.

i investigated and found the behavior started when i switched from the glob crate to the wax crate to handle glob patterns like **/code/sources.mlb. in that pattern, i would expect the ** to match 0 or more directories.

the wax crate has some surprising behavior with ** patterns that i documented in a test case repo here: https://github.com/azdavis/wax-trouble

and opened an issue about here: olson-sean-k/wax#61

i also just released millet v0.14.7 which switched back to the glob crate for globbing and should fix the issue you have observed.

@azdavis azdavis closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants