Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude files based on .sublime-settings and .project-settings files ? #82

Open
kl0tl opened this issue May 30, 2015 · 6 comments · May be fixed by #121
Open

Exclude files based on .sublime-settings and .project-settings files ? #82

kl0tl opened this issue May 30, 2015 · 6 comments · May be fixed by #121

Comments

@kl0tl
Copy link
Contributor

kl0tl commented May 30, 2015

Why not using the patterns defined in folder_exclude_patterns and file_exclude_patterns (plus folder_exclude_patterns and file_exclude_patterns if inside a project) to filter files instead of relying on dired_hidden_files_patterns ?
@vovkkk
Copy link
Collaborator

vovkkk commented May 30, 2015

Then exe and psd files will be hidden by default, but you can launch them with space, so it might be not desirable to hide them.
Maybe as an option, I dunno.

@kl0tl
Copy link
Contributor Author

kl0tl commented May 30, 2015

Couldn’t those files still be shown if needed with "include_file_patterns": ['*.exe', '*.psd'] inside the project‘s settings file? With a flag disabled by default it wouldn’t bite anyone.

@aziz
Copy link
Owner

aziz commented May 31, 2015

Even as an option shouldn't be on by default. let's keep this plugin closer to a file browser rather than a sidebar. Sublime will eventually add more features to the sidebar but file browsing features of this plugin will always be unique.

@kl0tl
Copy link
Contributor Author

kl0tl commented May 31, 2015

I’m not trying to mimic the sidebar, I use and like this plugin precisely because of those great file browsing features (great job btw !). I’m just confused by the upsides of using dired_hidden_files_patterns instead of taking advantage of the patterns that may already be defined inside the user’s preferences or project’s settings. Of course it shouldn’t be enabled by default. I could take a stab at it if can help !

@aziz
Copy link
Owner

aziz commented May 31, 2015

We appreciate any PR. I don't mind having a settings to integrate with sublime ignored files.

@vovkkk vovkkk mentioned this issue Apr 28, 2016
Closed
laggingreflex added a commit to laggingreflex/SublimeFileBrowser that referenced this issue Jul 1, 2016
@laggingreflex
Inherit file/folder_exclude_patterns from global settings
8404ade 
Uses `folder_exclude_patterns` and `file_exclude_patterns` patterns to match against directories and files respectively, and not include them in the index.

fixes aziz#82
@laggingreflex laggingreflex linked a pull request Jul 1, 2016 that will close this issue
Open
@denisinvader
Copy link

It would be nice to exclude files based on .gitignore file as well. Maybe by using one more option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inherit file/folder_exclude_patterns from global settings laggingreflex/SublimeFileBrowser
4 participants
@aziz @vovkkk @kl0tl @denisinvader