You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I currently ignored psl from being scoped to overcome the issue.
What also is a bit annoying: if you add something to PSL, you need to also include it in the loader.
Maybe we could make the loading part a bit more dynamic. I was thinking somewhere along the lines of dynamically building the CONSTANTS, FUNCTIONS, INTERFACES, ... and cache them in a php file the first time you load psl.
During development on psl's git repo, we could skip this caching step so that any additional file is recognised automatically?
An alternative could be: convert the constants into a lookup dictionarry with key FQCN and value the path to the file.
That way it works more or less how composer works internally
WDYT?
The text was updated successfully, but these errors were encountered:
veewee
added
the
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
label
Aug 19, 2022
and cache them in a php file the first time you load psl.
I don't think that's a good idea, i have worked on projects where vendor/ is set to be non-writable after deployment, so if that's the case, PSL will fail to create the file.
I'm open to other ideas that don't involve writing to files at runtime.
If you try to add psl to a phar (with box and scoper), the loader can not deal with scoped namespaces:
Resulting in:
I currently ignored psl from being scoped to overcome the issue.
What also is a bit annoying: if you add something to PSL, you need to also include it in the loader.
Maybe we could make the loading part a bit more dynamic. I was thinking somewhere along the lines of dynamically building the CONSTANTS, FUNCTIONS, INTERFACES, ... and cache them in a php file the first time you load psl.
During development on psl's git repo, we could skip this caching step so that any additional file is recognised automatically?
An alternative could be: convert the constants into a lookup dictionarry with key FQCN and value the path to the file.
That way it works more or less how composer works internally
WDYT?
The text was updated successfully, but these errors were encountered: