Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Backup Policy for SQLDatabase and SAPHanaDatabase #1843

Merged
merged 52 commits into from
Nov 16, 2023

Conversation

leethanh2112
Copy link
Contributor

@leethanh2112 leethanh2112 commented Oct 27, 2023

Issue-id

PR Checklist


Description

Does this introduce a breaking change

  • YES
  • NO

Testing

Tested inhouse

@leethanh2112
Copy link
Contributor Author

@iriahk89 Please help to review this PR.

Copy link
Contributor

@iriahk89 iriahk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should practice DRY (Dont Repeat Yourself) pattern as sqldb and saphanadb backup policy lies in same resource provider (azurerm_backup_policy_vm_workload) we should make the module generic enough to cater for both workload type. it should be able to identify the type within the module without the separation of those 2 workload.

@arnaudlh arnaudlh added enhancement New feature or request recovery vault labels Nov 8, 2023
@arnaudlh arnaudlh added this to the 5.7.7 milestone Nov 8, 2023
@leethanh2112
Copy link
Contributor Author

It seems like we're dealing with an error from Terraform syntax for 'SAPHanaDatabase. I will make a ticket to ask support from Hashicorp. @iriahk89 @khaman-pet

protectionpolicies.ProtectionPoliciesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error.
│ Status=400 Code="BMSUserErrorInvalidPolicyInput" Message="Input for create or update policy is not in proper format. Please check format of parameters like schedule time, schedule days, retention time and
│ retention days

Copy link
Contributor

@iriahk89 iriahk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh
Copy link
Member

thanks for the PR @leethanh2112 and thanks for the review @iriahk89!

@arnaudlh arnaudlh merged commit df0a1ae into aztfmod:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recovery vault
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants