-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Backup Policy for SQLDatabase and SAPHanaDatabase #1843
Conversation
@iriahk89 Please help to review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should practice DRY (Dont Repeat Yourself) pattern as sqldb and saphanadb backup policy lies in same resource provider (azurerm_backup_policy_vm_workload) we should make the module generic enough to cater for both workload type. it should be able to identify the type within the module without the separation of those 2 workload.
It seems like we're dealing with an error from Terraform syntax for 'SAPHanaDatabase. I will make a ticket to ask support from Hashicorp. @iriahk89 @khaman-pet protectionpolicies.ProtectionPoliciesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for the PR @leethanh2112 and thanks for the review @iriahk89! |
Issue-id
PR Checklist
Description
Does this introduce a breaking change
Testing
Tested inhouse