-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AKS Istio and Open service mesh support #1878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @trapeznikov, do you mind adding an example with the preview flags as described here: https://github.com/aztfmod/terraform-azurerm-caf/blob/azurerm-update-2401/examples/compute/kubernetes_services/104-private-cluster/aks.tfvars#L2 and add it to the JSON workflows for CI/CD to pick it up? Thanks!
@arnaudlh I added only Istio example, because Open Service Mesh project was archived by CNCF in favour of Istio. Do you want me to remove OSM config entirely, or keep both, but only one example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for your PR @trapeznikov |
PR Checklist
Description
Does this introduce a breaking change
Testing
Open Service Mesh:
Istio (This requires that the Preview Feature Microsoft.ContainerService/AzureServiceMeshPreview is enabled and the Resource Provider is re-registered, see the documentation for more information.)