Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AKS Istio and Open service mesh support #1878

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

trapeznikov
Copy link
Contributor

@trapeznikov trapeznikov commented Nov 30, 2023

PR Checklist


Description

Does this introduce a breaking change

  • YES
  • NO

Testing

Open Service Mesh:

Terraform will perform the following actions:

  # module.solution.module.aks_clusters["aks_re1"].azurerm_kubernetes_cluster.aks will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "aks" {
        id                                  = "/subscriptions/xxx/resourceGroups/poes-rg-aks-workloads-cac/providers/Microsoft.ContainerService/managedClusters/poes-aks-workloads-cac"
        name                                = "poes-aks-workloads-cac"
      ~ open_service_mesh_enabled           = false -> true
        tags                                = {
            "Env"             = "es"
            "caf_environment" = "es"
            "caf_level"       = "level3"
            "module"          = "aks"
            "rover_version"   = "aztfmod/rover:1.3.10-2311.0601"
        }
        # (28 unchanged attributes hidden)

        # (8 unchanged blocks hidden)
    }

Istio (This requires that the Preview Feature Microsoft.ContainerService/AzureServiceMeshPreview is enabled and the Resource Provider is re-registered, see the documentation for more information.)

  # module.solution.module.aks_clusters["aks_re1"].azurerm_kubernetes_cluster.aks will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "aks" {
        id                                  = "/subscriptions/xxx/resourceGroups/poes-rg-aks-workloads-cac/providers/Microsoft.ContainerService/managedClusters/poes-aks-workloads-cac"
        name                                = "poes-aks-workloads-cac"
        tags                                = {
            "Env"             = "es"
            "caf_environment" = "es"
            "caf_level"       = "level3"
            "module"          = "aks"
            "rover_version"   = "aztfmod/rover:1.3.10-2311.0601"
        }
        # (29 unchanged attributes hidden)

      + service_mesh_profile {
          + internal_ingress_gateway_enabled = true
          + mode                             = "Istio"
        }

        # (8 unchanged blocks hidden)
    }

@trapeznikov trapeznikov marked this pull request as draft December 1, 2023 14:50
@trapeznikov trapeznikov changed the title Add AKS open service mesh support Add AKS Istio and Open service mesh support Dec 1, 2023
@trapeznikov trapeznikov marked this pull request as ready for review December 1, 2023 19:26
@arnaudlh arnaudlh self-requested a review January 8, 2024 06:57
@arnaudlh arnaudlh added enhancement New feature or request aks labels Jan 8, 2024
@arnaudlh arnaudlh added this to the 5.7.8 milestone Jan 8, 2024
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @trapeznikov, do you mind adding an example with the preview flags as described here: https://github.com/aztfmod/terraform-azurerm-caf/blob/azurerm-update-2401/examples/compute/kubernetes_services/104-private-cluster/aks.tfvars#L2 and add it to the JSON workflows for CI/CD to pick it up? Thanks!

@arnaudlh arnaudlh removed this from the 5.7.8 milestone Jan 12, 2024
@arnaudlh arnaudlh added the question Further information is requested label Jan 24, 2024
@trapeznikov
Copy link
Contributor Author

@arnaudlh I added only Istio example, because Open Service Mesh project was archived by CNCF in favour of Istio. Do you want me to remove OSM config entirely, or keep both, but only one example?

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added this to the 5.7.11 milestone Apr 23, 2024
@arnaudlh arnaudlh merged commit 3dc5487 into aztfmod:main Apr 23, 2024
@arnaudlh
Copy link
Member

thanks for your PR @trapeznikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aks enhancement New feature or request question Further information is requested
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants