Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VPN Gateway Connection Routing #1957

Merged

Conversation

trapeznikov
Copy link
Contributor

1926

PR Checklist


Description

Current routing block has the following error:

  • associated_route_table can be set to any custom table, but based on documentation and error, it can only be set to Default Route Table
  • propagated_route_table block is not working and errors out
  • labels block is not working and errors out

Fix:

  • associated_route_table now defaults to Default Route Table when not set (I kept the existing code that allows setting custom route tables, in case it works in old versions of provider or may be supported in the future
  • propagated_route_table now wraps route tables into route_tables
  • labels is now inside route_tables to associate labels for each routing table

Does this introduce a breaking change

  • YES
  • NO

Current code is broken and results into errors described in 1926
If you currently have propagated_route_table in your code, add route_tables. If you have associated_route_table set to anything other than Default Route Table, it doesn't seem to be supported, so now it will be added by default if associated_route_table is not in the code. Please refer to changes in example examples/networking/virtual_wan/109-vwan-vpn-gateway-connection/virtual_wan.tfvars

Testing

Run example examples/networking/virtual_wan/109-vwan-vpn-gateway-connection/virtual_wan.tfvars

I was able to successfully run it in my testing.
Apply complete! Resources: 17 added, 0 changed, 0 destroyed.

@arnaudlh arnaudlh linked an issue Apr 22, 2024 that may be closed by this pull request
1 task
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your PR @trapeznikov

@arnaudlh arnaudlh added this to the 5.7.12 milestone May 27, 2024
@arnaudlh arnaudlh merged commit a2628f1 into aztfmod:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug report- Virtual WAN VPN Gateway Connection Route Tables
2 participants