Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added centralized private endpoint for cognitive services account #1968

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

bbmilan
Copy link
Contributor

@bbmilan bbmilan commented Apr 22, 2024

Issue-id

PR Checklist


Description

Does this introduce a breaking change

  • YES
  • NO

Testing

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @bbmilan, it looks good to me.
Are you able to take a look at the in-module approach as well as illustrated here: https://github.com/aztfmod/terraform-azurerm-caf/blob/main/modules/redis_cache/private_endpoints.tf
It would be a good addition to have it inside the module also so both centralized (as your PR add) and decentralized (link in example).

@arnaudlh arnaudlh added documentation Improvements or additions to documentation enhancement New feature or request private endpoints cognitive services openai labels Jun 3, 2024
@arnaudlh arnaudlh added this to the 5.7.12 milestone Jun 3, 2024
@arnaudlh arnaudlh changed the title added private endpoint for cognitive services account with an example of how to use it Added centralized private endpoint for cognitive services account Jun 3, 2024
@arnaudlh arnaudlh merged commit f411752 into aztfmod:main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cognitive services documentation Improvements or additions to documentation enhancement New feature or request openai private endpoints
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants