Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage defender support #2030

Conversation

shanoor
Copy link
Contributor

@shanoor shanoor commented Jul 2, 2024

PR Checklist


Description

Add support for enabling Defender for Storage on a storage account.

Does this introduce a breaking change

  • YES
  • NO

Testing

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shanoor, are you able to change it to default the values to the provider instead of the module?
Can you please also add an example and the CI/CD line?

modules/storage_account/storage_defender.tf Outdated Show resolved Hide resolved
modules/storage_account/storage_defender.tf Outdated Show resolved Hide resolved
modules/storage_account/storage_defender.tf Outdated Show resolved Hide resolved
modules/storage_account/storage_defender.tf Outdated Show resolved Hide resolved
@arnaudlh arnaudlh added enhancement New feature or request storage services labels Jul 4, 2024
@arnaudlh arnaudlh added this to the 5.7.13 milestone Jul 4, 2024
shanoor and others added 5 commits July 5, 2024 12:20
Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
Co-authored-by: Arnaud Lheureux <arnaudlh@users.noreply.github.com>
@shanoor
Copy link
Contributor Author

shanoor commented Jul 5, 2024

Thanks for the PR @shanoor, are you able to change it to default the values to the provider instead of the module? Can you please also add an example and the CI/CD line?

I committed your suggestions and added an example.

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arnaudlh arnaudlh merged commit edf2616 into aztfmod:main Jul 23, 2024
139 checks passed
@shanoor shanoor deleted the feat/visiativ/add-storage-defender-support branch July 31, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request storage services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants