fix: improve 404 logics #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Jun 24, 2021
lib/can-npm-publish.js
Outdated
| // FIXME: However,This logics will break json chunk(chunk may be invalid json) | ||
| // https://github.com/azu/can-npm-publish/issues/19 | ||
| // https://github.com/npm/cli/issues/2740 | ||
| JSON.parse(stdErrorStr); // parse check |
There was a problem hiding this comment.
There was a problem hiding this comment.
npm 7 outputs
"npm"
"Err!"
""
"JSON strings..."
""
...
There was a problem hiding this comment.
This logic will break following pattern
"npm"
"Err!"
""
"JSON part1"
"JSON part2"
""
There was a problem hiding this comment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--jsonoutput include non JSON string.--jsonoutput JSON string into stderr--jsonoutput JSON string into stdoutFor the reason, We need to parse stdout and stderr.
fix #19