Add support for registry definition in package.json publishConfig #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Jun 20, 2018
lib/can-npm-publish.js
Outdated
| return new Promise((resolve, reject) => { | ||
| const view = spawn("npm", ["view", packageName, "versions", "--json"]); | ||
| const view = spawn("npm", ["view", packageName, "versions", "--json", registry && `--registry=${registry}`]); |
There was a problem hiding this comment.
Can you change this as follows?
const registryArgs = registry ? [`--registry=${registry}`] : [];
const view = spawn("npm", ["view", packageName, "versions", "--json"].concat(registryArgs));Because, I not want to put undefined value into spawn's arguments.
var registry = undefined;
["a", registry && `--registry=${registry}`];
// ["a", undefined]
var registryArgs = registry ? [`--registry=${registry}`] : [];
["a"].concat(registryArgs);
// ["a"]There was a problem hiding this comment.
Yes, thats definatly better.
azu
reviewed
Jun 20, 2018
| @@ -37,9 +37,9 @@ const checkPrivateField = packagePath => { | |||
| * @param packageName | |||
There was a problem hiding this comment.
We can add @param {string} [registry] to JSDoc.
|
1.2.0 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an alternative/private registry is defined in package.json publishConfig, npmjs.org registry will still be used.
This adds support by reading the registry field in package.json and passing it to
npm viewwith the--registryargument.Added tests using the Yarn registry as an alternative registry.