New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use `String.prototype.includes` for URL string #2

Open

1 task

azu opened this issue Dec 13, 2022 · 1 comment

Owner

azu commented Dec 13, 2022 •

edited

Loading

includes method is not suitable for almost cases in URL manipulation.
Instead of it, you should use === instead of includes.

relative link detection
subdomain detection
same origin detection

TODO

Need Examples

The text was updated successfully, but these errors were encountered:

Owner Author

azu commented Aug 17, 2023

isLocalLink is not local excalidraw/excalidraw#6901

azu changed the title ~~Do not use String.prototype.includes for URL~~ Do not use String.prototype.includes for URL string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment