feat: --no-restage flag for skipping re-stage step in staged mode (#39)

[benwiley4000]

Fixes #39

[benwiley4000]

Oops, mis-typed the name of the flag in the docs. I'll force push the corrected version.

[benwiley4000]

All good now!

[azz]

Looks like the tests fail now. Could you investigate that, and also add a new test for this flag?

 FAILsrc/__tests__/scm-git.test.js
●with git › with --staged stages fully-staged files
expect(jest.fn()).toHaveBeenCalledWith(expected)
    Expected mock function to have been called with:
["add", "./raz.js"] as argument 2, but it was called with["ls-files", "--others", "--exclude-standard"].
["add", "./raz.js"] as argument 2, but it was called with["diff", "--name-only", "--diff-filter=ACMRTUB"].
["add", "./raz.js"] as argument 2, but it was called with["diff", "--name-only", "--cached", "--diff-filter=ACMRTUB", "banana"].
 172 |    prettyQuick('root' { since:'banana' staged:true });
 173 |
> 174 |    expect(execa.sync).toHaveBeenCalledWith('git' ['add''./raz.js'] {
 175 |      cwd:'/'
 176 |    });
 177 |    expect(execa.sync).not.toHaveBeenCalledWith('git' ['add''./foo.md'] {
at Object.test (src/__tests__/scm-git.test.js:174:34)

[benwiley4000]

Oops! I'll check it out, thanks for flagging. Le mar. 18 sept. 2018 06 h 04, Lucas Azzola <notifications@github.com> a écrit :

…

Looks like the tests fail now. Could you investigate that, and also add a new test for this flag? FAILsrc/__tests__/scm-git.test.js ●with git › with --staged stages fully-staged files expect(jest.fn()).toHaveBeenCalledWith(expected) Expected mock function to have been called with: ["add", "./raz.js"] as argument 2, but it was called with["ls-files", "--others", "--exclude-standard"]. ["add", "./raz.js"] as argument 2, but it was called with["diff", "--name-only", "--diff-filter=ACMRTUB"]. ["add", "./raz.js"] as argument 2, but it was called with["diff", "--name-only", "--cached", "--diff-filter=ACMRTUB", "banana"]. 172 | prettyQuick('root' { since:'banana' staged:true }); 173 | > 174 | expect(execa.sync).toHaveBeenCalledWith('git' ['add''./raz.js'] { 175 | cwd:'/' 176 | }); 177 | expect(execa.sync).not.toHaveBeenCalledWith('git' ['add''./foo.md'] { at Object.test (src/__tests__/scm-git.test.js:174:34) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AM7h7c_2GjqCaoZq49thlOqMAGQ9rLdlks5ucMU8gaJpZM4WtID3> .

[benwiley4000]

@azz I made a fix to pass the failing test, added a new test, and a commit at the end to change "foo.md" to "foo.js" since I assumed that was a typo. If not, I can get rid of that commit.

[azz]

Thanks!

[benwiley4000]

Thank you! :)