Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the encoding process #1014

Closed
yuto-trd opened this issue Jul 4, 2024 · 0 comments · Fixed by #1029
Closed

Invert the encoding process #1014

yuto-trd opened this issue Jul 4, 2024 · 0 comments · Fixed by #1029
Labels
area-extensibility Beutl.Extensibilityや拡張機能に関するIssue enhancement New feature or request

Comments

@yuto-trd
Copy link
Member

yuto-trd commented Jul 4, 2024

Is your feature request related to a problem? Please describe.

Currently, the extension cannot fully control the encoding process, and it is not possible to change the order in which video and audio frames are passed, with all video frames being passed first followed by the audio frames.

Describe the solution you'd like

Instead of passing frames directly to the encoder, pass a class that generates the frames

public class ControllableEncodingExtension
{
    public EncodingController CreateController(string file);
}

public class EncodingController
{
    public EncodingController(string file, IFrameProvider fp, ISampleProvider sp);

    public string OutputFile { get; }
    public abstract VideoEncodingSettings  VideoConfig { get; }
    public abstract AudioEncodingSettings  AudioConfig { get; }

    public abstract Task Run(CancellationToken ct = default);
}

Describe alternatives you've considered

No response

Additional context

No response

@yuto-trd yuto-trd added enhancement New feature or request area-extensibility Beutl.Extensibilityや拡張機能に関するIssue labels Jul 4, 2024
@yuto-trd yuto-trd closed this as completed Aug 2, 2024
@yuto-trd yuto-trd linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-extensibility Beutl.Extensibilityや拡張機能に関するIssue enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant