Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creating a resource with root bundle ID #1036

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

cmark
Copy link
Member

@cmark cmark commented Jun 28, 2022

This PR depends on #1035

@cmark cmark self-assigned this Jun 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1036 (ff62a28) into 8.x (eb9d3ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                8.x    #1036   +/-   ##
=========================================
  Coverage     65.01%   65.01%           
- Complexity    12261    12262    +1     
=========================================
  Files          1701     1701           
  Lines         56522    56533   +11     
  Branches       5224     5224           
=========================================
+ Hits          36748    36757    +9     
  Misses        17535    17535           
- Partials       2239     2241    +2     
Impacted Files Coverage Δ
...owowl/core/rest/domain/BaseResourceRestSearch.java 68.42% <100.00%> (+5.92%) ⬆️
...nowowl/core/rest/resource/ResourceRestService.java 96.29% <100.00%> (+0.14%) ⬆️
...tional/snowowl/core/internal/ResourceDocument.java 93.87% <100.00%> (+0.03%) ⬆️
...nowowl/core/request/BaseResourceCreateRequest.java 88.57% <100.00%> (+0.22%) ⬆️
...nowowl/core/request/BaseResourceSearchRequest.java 97.72% <100.00%> (+0.08%) ⬆️
...core/request/BaseResourceSearchRequestBuilder.java 82.35% <100.00%> (+1.10%) ⬆️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 85.10% <0.00%> (-2.13%) ⬇️
...national/index/revision/BaseRevisionBranching.java 89.47% <0.00%> (-1.17%) ⬇️
...index/src/com/b2international/index/es/EsNode.java 81.25% <0.00%> (-1.05%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 85.01% <0.00%> (-0.26%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9d3ce...ff62a28. Read the comment docs.

Copy link
Contributor

@molnarlaura molnarlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@apeteri apeteri merged commit 735243b into 8.x Jun 29, 2022
@apeteri apeteri deleted the issue/prevent-creating-resource-with-root-bundle-id branch June 29, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants