Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to acccess TestContext.Renderer without putting TestServiceProvider into provider mode #333

Closed
egil opened this issue Feb 24, 2021 · 2 comments
Closed

Make it possible to acccess TestContext.Renderer without putting TestServiceProvider into provider mode #333

egil opened this issue Feb 24, 2021 · 2 comments
Labels
backlog Enhancements which are relevant but not a priority at the moment. enhancement New feature or request
Milestone
2.0.0

Comments

@egil
Copy link
Member

egil commented Feb 24, 2021 •
edited
Loading

The ITestRenderer is being pulled from the TestServiceProvider lazily the first time it is requested. However, this is not really a good design decision, since it a property should not have side effects like this. Its surprising to the user.

However, in the interest of not breaking the API for v1, I think this has to stay as is for now.
@egil egil added backlog Enhancements which are relevant but not a priority at the moment. enhancement New feature or request labels Mar 9, 2021
@egil egil added this to the 2.0.0 milestone May 26, 2022
@linkdotnet
Copy link
Collaborator

That would be obsolete if we do #1018

@egil
Copy link
Member Author

egil commented May 20, 2023

Perhaps. We need the renderer in relation to MarkupMatches and a few other places. Will need to investigate.

@egil egil closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Enhancements which are relevant but not a priority at the moment. enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@egil @linkdotnet