Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false defaults ignored/removed #96

Closed
eval opened this issue Mar 27, 2024 · 1 comment · Fixed by #97
Closed

false defaults ignored/removed #96

eval opened this issue Mar 27, 2024 · 1 comment · Fixed by #97

Comments

@eval
Copy link
Contributor

eval commented Mar 27, 2024

Some spots where a default set to false are ignored/removed:

user=> (cli/spec->opts {:flag {:default false} :flag2 {:default true}})
{:exec-args {:flag2 true}}

user=> (cli/format-opts {:spec {:flag {:default false} :flag2 {:default true}}})
"  --flag\n  --flag2 true"

Can provide a patch.
@borkdude
Copy link
Contributor

patch welcome

@eval eval mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent false defaults from being removed/ignored eval/cli
2 participants
@borkdude @eval